[Docs] Fix duplicate license headers and incorrect module paths after tirx rename#18941
Merged
tlopex merged 1 commit intoapache:mainfrom Mar 27, 2026
Merged
[Docs] Fix duplicate license headers and incorrect module paths after tirx rename#18941tlopex merged 1 commit intoapache:mainfrom
tlopex merged 1 commit intoapache:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request cleans up redundant license headers in the documentation and updates the architecture guide to reflect the correct directory structure for schedule primitives and tensor intrinsics. A suggestion was made to improve the flow and readability of the updated section in the architecture documentation.
Comment on lines
310
to
+315
| Besides the IR data structures, the tirx module also includes: | ||
|
|
||
| - A set of schedule primitives to control the generated code in ``tirx/schedule``. | ||
| - A set of builtin intrinsics in ``tirx/tensor_intrin``. | ||
| - A set of analysis passes to analyze the tirx functions in ``tirx/analysis``. | ||
| - A set of transformation passes to lower or optimize the tirx functions in ``tirx/transform``. | ||
|
|
||
| The schedule primitives and tensor intrinsics are in ``s_tir/schedule`` and ``s_tir/tensor_intrin`` respectively. |
Contributor
There was a problem hiding this comment.
While the information presented is now correct, the structure feels a bit disjointed. To improve readability and flow, consider rephrasing this section to better integrate the information about s_tir. Here is a suggestion that maintains the list format for clarity:
Suggested change
| Besides the IR data structures, the tirx module also includes: | |
| - A set of schedule primitives to control the generated code in ``tirx/schedule``. | |
| - A set of builtin intrinsics in ``tirx/tensor_intrin``. | |
| - A set of analysis passes to analyze the tirx functions in ``tirx/analysis``. | |
| - A set of transformation passes to lower or optimize the tirx functions in ``tirx/transform``. | |
| The schedule primitives and tensor intrinsics are in ``s_tir/schedule`` and ``s_tir/tensor_intrin`` respectively. | |
| Besides the IR data structures, the tirx module includes: | |
| - A set of analysis passes to analyze the tirx functions in ``tirx/analysis``. | |
| - A set of transformation passes to lower or optimize the tirx functions in ``tirx/transform``. | |
| Note that the related schedule primitives and tensor intrinsics are located in ``s_tir/schedule`` and ``s_tir/tensor_intrin`` respectively. |
tqchen
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/get_started/overview.rstanddocs/README.mdintroduced by [Refactor] Bring up tirx namespace #18913, which render as visible garbage text in built documentationtirx/scheduleandtirx/tensor_intrinpaths indocs/arch/index.rst— these modules are ins_tir/, nottirx/